-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: do not directly update global stats when dropping a partition #48846
statistics: do not directly update global stats when dropping a partition #48846
Conversation
…tion Signed-off-by: hi-rustin <rustin.liu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48846 +/- ##
=================================================
- Coverage 71.0083% 53.8932% -17.1151%
=================================================
Files 1367 1587 +220
Lines 404865 601500 +196635
=================================================
+ Hits 287488 324168 +36680
- Misses 97372 254810 +157438
- Partials 20005 22522 +2517
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
What problem does this PR solve?
Issue Number: ref #48182 (comment)
Problem Summary:
What changed and how does it work?
Based on this design doc, we will only update the
count
andmodfiy_count
for it. Then it will use thecount
andmodify_count
to determine if we need to trigger an auto-analysis task.So in this PR, I dropped the update global stats operation.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.