Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: fix typo because lightning supports sql/parquet data files but csv. #48655

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

joccau
Copy link
Member

@joccau joccau commented Nov 17, 2023

What problem does this PR solve?

As title.

Issue Number: close #48654

Problem Summary:

  • the comments is "source csv files is proper" when lightning imports the parquet data files, which could confuse the DBA.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
  • I checked and no code files have been changed.

manual test

  • after fix it
+----+------------------------------------------------------------------------------------------------------------------------------------+-------------+--------+
|  # | CHECK ITEM                                                                                                                         | TYPE        | PASSED |
+----+------------------------------------------------------------------------------------------------------------------------------------+-------------+--------+
|  1 | Source data files size is proper                                                                                                   | performance | true   |
+----+------------------------------------------------------------------------------------------------------------------------------------+-------------+--------+
|  2 | the checkpoints are valid                                                                                                          | critical    | true   |
+----+------------------------------------------------------------------------------------------------------------------------------------+-------------+--------+
|  3 | table schemas are valid                                                                                                            | critical    | true   |
+----+------------------------------------------------------------------------------------------------------------------------------------+-------------+--------+

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: joccau <zak.zhao@pingcap.com.cn>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Nov 17, 2023
@joccau joccau self-assigned this Nov 17, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #48655 (cb707e3) into master (1b58a8d) will increase coverage by 1.5742%.
Report is 4 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48655        +/-   ##
================================================
+ Coverage   71.1823%   72.7566%   +1.5742%     
================================================
  Files          1365       1389        +24     
  Lines        404155     411443      +7288     
================================================
+ Hits         287687     299352     +11665     
+ Misses        96537      93229      -3308     
+ Partials      19931      18862      -1069     
Flag Coverage Δ
integration 43.7790% <ø> (?)
unit 71.1883% <100.0000%> (+0.0060%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8458% <100.0000%> (-4.2596%) ⬇️

Copy link

ti-chi-bot bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2023
Copy link

ti-chi-bot bot commented Nov 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-17 04:05:48.300106778 +0000 UTC m=+4394745.887216908: ☑️ agreed by lance6716.
  • 2023-11-17 04:14:12.13597649 +0000 UTC m=+4395249.723086620: ☑️ agreed by glorv.

Copy link

tiprow bot commented Nov 17, 2023

@joccau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 7ba4109 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@glorv
Copy link
Contributor

glorv commented Nov 17, 2023

/retest

@joccau
Copy link
Member Author

joccau commented Nov 17, 2023

/merge

Copy link

ti-chi-bot bot commented Nov 17, 2023

You are out of date.
@joccau: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: joccau <zak.zhao@pingcap.com.cn>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 557599f into pingcap:master Nov 17, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lightning: typo(the comment is the "source csv files is proper" but the sql file is importing)
3 participants