-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Move sort tests to sortexec
package
#48636
Conversation
Hi @xzhangxian1008. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48636 +/- ##
================================================
+ Coverage 71.2233% 72.6488% +1.4254%
================================================
Files 1360 1389 +29
Lines 403758 410787 +7029
================================================
+ Hits 287570 298432 +10862
+ Misses 96260 93453 -2807
+ Partials 19928 18902 -1026
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/cc @SeaRise @hawkingrei |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, SeaRise The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #47733
Problem Summary:
What is changed and how it works?
TestSortSpillDisk
in executor_pkg_test.go intosortexec
packagesortexec
packagetestutil
packageagg
,limit
,sort
andwindow
utilities into testutil packageCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.