Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Move sort tests to sortexec package #48636

Merged
merged 12 commits into from
Nov 17, 2023

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Nov 16, 2023

What problem does this PR solve?

Issue Number: ref #47733

Problem Summary:

What is changed and how it works?

  • Move TestSortSpillDisk in executor_pkg_test.go into sortexec package
  • Move benchmark test of sort in benchmark_test.go into sortexec package
  • Move some common test util into testutil package
  • Move agg, limit, sort and window utilities into testutil package

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2023
Copy link

tiprow bot commented Nov 16, 2023

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008 xzhangxian1008 mentioned this pull request Nov 16, 2023
13 tasks
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #48636 (899f326) into master (15f7b6e) will increase coverage by 1.4254%.
Report is 7 commits behind head on master.
The diff coverage is 32.7800%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48636        +/-   ##
================================================
+ Coverage   71.2233%   72.6488%   +1.4254%     
================================================
  Files          1360       1389        +29     
  Lines        403758     410787      +7029     
================================================
+ Hits         287570     298432     +10862     
+ Misses        96260      93453      -2807     
+ Partials      19928      18902      -1026     
Flag Coverage Δ
integration 43.3395% <0.4149%> (?)
unit 71.1858% <32.3651%> (-0.0376%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8155% <ø> (-4.2467%) ⬇️

@xzhangxian1008
Copy link
Contributor Author

/cc @SeaRise @hawkingrei

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2023
Copy link

ti-chi-bot bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2023
Copy link

ti-chi-bot bot commented Nov 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-17 02:59:32.319162272 +0000 UTC m=+4390769.906272416: ☑️ agreed by hawkingrei.
  • 2023-11-17 03:04:00.079387638 +0000 UTC m=+4391037.666497783: ☑️ agreed by SeaRise.

@ti-chi-bot ti-chi-bot bot merged commit 1b58a8d into pingcap:master Nov 17, 2023
16 checks passed
@xzhangxian1008 xzhangxian1008 deleted the mv-sort-tests branch November 17, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants