-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: support resource control for stats #48618
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48618 +/- ##
=================================================
+ Coverage 71.4240% 83.1370% +11.7130%
=================================================
Files 1404 2563 +1159
Lines 407213 749882 +342669
=================================================
+ Hits 290848 623430 +332582
- Misses 96412 104194 +7782
- Partials 19953 22258 +2305
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -94,6 +95,7 @@ func CallWithSCtx(pool SessionPool, f func(sctx sessionctx.Context) error, flags | |||
} | |||
}() | |||
sctx := se.(sessionctx.Context) | |||
sctx.GetSessionVars().ExplicitRequestSourceType = kvutil.ExplicitTypeStats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to get sessionvar from other internal SQLs, like from ddl module?
/test all |
1 similar comment
/test all |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@hawkingrei: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #44517
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.