Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: support resource control for stats #48618

Closed
wants to merge 1 commit into from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 15, 2023

What problem does this PR solve?

Issue Number: ref #44517

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2023
Copy link

ti-chi-bot bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #48618 (c953cfe) into master (1c8d383) will increase coverage by 11.7130%.
Report is 893 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #48618         +/-   ##
=================================================
+ Coverage   71.4240%   83.1370%   +11.7130%     
=================================================
  Files          1404       2563       +1159     
  Lines        407213     749882     +342669     
=================================================
+ Hits         290848     623430     +332582     
- Misses        96412     104194       +7782     
- Partials      19953      22258       +2305     
Flag Coverage Δ
integration 28.0045% <100.0000%> (?)
unit 82.2601% <100.0000%> (+10.8360%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6721% <ø> (+19.6846%) ⬆️
parser ∅ <ø> (∅)
br 72.2661% <ø> (+19.1806%) ⬆️

@@ -94,6 +95,7 @@ func CallWithSCtx(pool SessionPool, f func(sctx sessionctx.Context) error, flags
}
}()
sctx := se.(sessionctx.Context)
sctx.GetSessionVars().ExplicitRequestSourceType = kvutil.ExplicitTypeStats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get sessionvar from other internal SQLs, like from ddl module?

@hawkingrei
Copy link
Member Author

/test all

1 similar comment
@hawkingrei
Copy link
Member Author

/test all

Copy link

tiprow bot commented Dec 20, 2023

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test c953cfe link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Feb 17, 2024

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build c953cfe link true /test build
idc-jenkins-ci-tidb/check_dev c953cfe link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hawkingrei hawkingrei closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants