-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: always use the ctx in parameter for method Equal
in all expressions
#48596
Conversation
Eval
in all …Eval
in all expressions
Eval
in all expressionsEqual
in all expressions
bc98b04
to
5f6b4f7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48596 +/- ##
================================================
+ Coverage 71.4230% 74.0796% +2.6565%
================================================
Files 1404 1435 +31
Lines 407220 424080 +16860
================================================
+ Hits 290849 314157 +23308
+ Misses 96417 91247 -5170
+ Partials 19954 18676 -1278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5f6b4f7
to
3e3a07a
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test all |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: winoros, XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What problem does this PR solve?
Issue Number: close #48595
What is changed and how it works?
EqualColum
toColumn
andCorrelatedColumn
to avoid context input when determining two columns are equal.ctx
instead of the inner context for allExpression.Equal
methods.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.