Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: always use the ctx in parameter for method Equal in all expressions #48596

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Nov 15, 2023

What problem does this PR solve?

Issue Number: close #48595

What is changed and how it works?

  • Add a new method EqualColum to Column and CorrelatedColumn to avoid context input when determining two columns are equal.
  • Always use parameter ctx instead of the inner context for all Expression.Equal methods.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 15, 2023
@lcwangchao lcwangchao changed the title expression: always use the ctx in parameter for method Eval in all … expression: always use the ctx in parameter for method Eval in all expressions Nov 15, 2023
@lcwangchao lcwangchao changed the title expression: always use the ctx in parameter for method Eval in all expressions expression: always use the ctx in parameter for method Equal in all expressions Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #48596 (3e3a07a) into master (625dc4e) will increase coverage by 2.6565%.
Report is 25 commits behind head on master.
The diff coverage is 84.6846%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48596        +/-   ##
================================================
+ Coverage   71.4230%   74.0796%   +2.6565%     
================================================
  Files          1404       1435        +31     
  Lines        407220     424080     +16860     
================================================
+ Hits         290849     314157     +23308     
+ Misses        96417      91247      -5170     
+ Partials      19954      18676      -1278     
Flag Coverage Δ
integration 45.1189% <76.5765%> (?)
unit 72.7799% <76.6355%> (+1.3568%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8130% <ø> (-4.2687%) ⬇️

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 16, 2023
@hawkingrei
Copy link
Member

/test all

@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 16, 2023
Copy link

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-16 02:22:53.724949812 +0000 UTC m=+4302171.312059956: ☑️ agreed by YangKeao.
  • 2023-11-16 15:23:13.71421276 +0000 UTC m=+4348991.301322905: ☑️ agreed by winoros.

Copy link

ti-chi-bot bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros, XuHuaiyu, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 17, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2f2f916 into pingcap:master Nov 17, 2023
13 of 16 checks passed
@lcwangchao lcwangchao deleted the equal_ctx branch November 17, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression.Equal should always use the ctx in parameter
5 participants