backup: add table-concurrency to control backup tableInfo stats and checksum. #48570

3pointer · 2023-11-14T03:01:23Z

What problem does this PR solve?

Issue Number: close #48571
Problem Summary:
checksum and backup stats does have impact on cluster. so public the parameter with table-concurrency. which means the concurrency of backup all table metas. including backup tableInfos/stats and checksum.

What is changed and how it works?

Public internal parameter to configuration.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…hecksum

ti-chi-bot · 2023-11-14T03:01:26Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2023-11-14T03:01:40Z

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benmaoer

LGTM

ti-chi-bot · 2023-11-15T07:07:41Z

@benmaoer: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-11-15T07:28:11Z

Codecov Report

Merging #48570 (bc64996) into master (50237bd) will increase coverage by 1.3816%.
Report is 27 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #48570        +/-   ##
================================================
+ Coverage   71.4258%   72.8074%   +1.3816%     
================================================
  Files          1403       1430        +27     
  Lines        407207     414191      +6984     
================================================
+ Hits         290851     301562     +10711     
+ Misses        96405      93666      -2739     
+ Partials      19951      18963       -988

Flag	Coverage Δ
integration	`43.6074% <0.0000%> (?)`
unit	`71.3668% <ø> (-0.0590%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9874% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.8190% <0.0000%> (-4.2723%)`	⬇️

br/pkg/task/backup.go

hawkingrei · 2023-11-16T05:11:28Z

br/pkg/task/backup.go

@@ -718,7 +726,7 @@ func RunBackup(c context.Context, g glue.Glue, cmdName string, cfg *BackupConfig
 		}
 	}
 	updateCh = g.StartProgress(ctx, "Checksum", checksumProgress, !cfg.LogProgress)
-	schemasConcurrency := uint(min(backup.DefaultSchemaConcurrency, schemas.Len()))


backup.DefaultSchemaConcurrency can be removed.

it used as initial value for the new config

Isn't a default value of 64 a bit too high? Should the default setting be more conservative?

two reasons to keep it 64

to keep the compatibility.

to keep checksum performance.

Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>

…into schema-concurrency

BornChanger · 2023-11-16T11:16:36Z

/retest

tiprow · 2023-11-16T11:16:59Z

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-11-16T11:18:18Z

/label affects-7.5

3pointer · 2023-11-16T14:13:57Z

/test unit-test

tiprow · 2023-11-16T14:14:21Z

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-11-16T15:28:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmaoer, BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~br/OWNERS~~ [BornChanger,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-11-16T15:28:38Z

[LGTM Timeline notifier]

Timeline:

2023-11-16 11:17:39.284510912 +0000 UTC m=+4334256.871621059: ☑️ agreed by BornChanger.
2023-11-16 15:28:37.164581514 +0000 UTC m=+4349314.751691644: ☑️ agreed by YuJuncen.

ti-chi-bot · 2023-11-16T16:07:03Z

@BornChanger: The label(s) needs-cherry-pick-7.5 cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, affects-5.3, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, may-affects-5.3, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5.

In response to this:

/label needs-cherry-pick-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-16T16:07:24Z

@BornChanger: The label(s) needs-cherry-pick-7.5 cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, affects-5.3, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, may-affects-5.3, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5.

In response to this:

/label needs-cherry-pick-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

BornChanger · 2023-11-16T16:07:27Z

/label needs-cherry-pick-release-7.5

ti-chi-bot · 2023-11-16T16:08:12Z

In response to a cherrypick label: new pull request created to branch release-7.5: #48652.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

…hecksum. (#48570) (#48652) close #48571

backup: add table-concurrency to control backup tableInfo stats and c…

177aa50

…hecksum

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Nov 14, 2023

benmaoer approved these changes Nov 15, 2023

View reviewed changes

3pointer marked this pull request as ready for review November 15, 2023 07:12

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2023

BornChanger reviewed Nov 15, 2023

View reviewed changes

br/pkg/task/backup.go Outdated Show resolved Hide resolved

hawkingrei reviewed Nov 16, 2023

View reviewed changes

3pointer and others added 3 commits November 16, 2023 13:41

Update br/pkg/task/backup.go

8e7e651

Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>

fix build

bbe4441

Merge branch 'schema-concurrency' of https://github.com/3pointer/tidb …

1cf7499

…into schema-concurrency

BornChanger approved these changes Nov 16, 2023

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 16, 2023

ti-chi-bot bot added the affects-7.5 label Nov 16, 2023

fix

bc64996

YuJuncen approved these changes Nov 16, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 16, 2023

ti-chi-bot bot merged commit 07057bd into pingcap:master Nov 16, 2023
16 of 20 checks passed

ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 16, 2023

ti-chi-bot mentioned this pull request Nov 16, 2023

backup: add table-concurrency to control backup tableInfo stats and checksum. (#48570) #48652

Merged

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 16, 2023

This is an automated cherry-pick of pingcap#48570

0bd41ed

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot bot pushed a commit that referenced this pull request Nov 17, 2023

backup: add table-concurrency to control backup tableInfo stats and c…

56cccb6

…hecksum. (#48570) (#48652) close #48571

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

backup: add table-concurrency to control backup tableInfo stats and checksum. #48570

backup: add table-concurrency to control backup tableInfo stats and checksum. #48570

3pointer commented Nov 14, 2023 •

edited

Loading

ti-chi-bot bot commented Nov 14, 2023

tiprow bot commented Nov 14, 2023

benmaoer left a comment

ti-chi-bot bot commented Nov 15, 2023

codecov bot commented Nov 15, 2023 •

edited

Loading

hawkingrei Nov 16, 2023

3pointer Nov 16, 2023

hawkingrei Nov 16, 2023

3pointer Nov 16, 2023

BornChanger commented Nov 16, 2023

tiprow bot commented Nov 16, 2023

BornChanger commented Nov 16, 2023

3pointer commented Nov 16, 2023

tiprow bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

BornChanger commented Nov 16, 2023

ti-chi-bot commented Nov 16, 2023

backup: add table-concurrency to control backup tableInfo stats and checksum. #48570

backup: add table-concurrency to control backup tableInfo stats and checksum. #48570

Conversation

3pointer commented Nov 14, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Nov 14, 2023

tiprow bot commented Nov 14, 2023

benmaoer left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Nov 15, 2023

codecov bot commented Nov 15, 2023 • edited Loading

Codecov Report

hawkingrei Nov 16, 2023

Choose a reason for hiding this comment

3pointer Nov 16, 2023

Choose a reason for hiding this comment

hawkingrei Nov 16, 2023

Choose a reason for hiding this comment

3pointer Nov 16, 2023

Choose a reason for hiding this comment

BornChanger commented Nov 16, 2023

tiprow bot commented Nov 16, 2023

BornChanger commented Nov 16, 2023

3pointer commented Nov 16, 2023

tiprow bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

BornChanger commented Nov 16, 2023

ti-chi-bot commented Nov 16, 2023

3pointer commented Nov 14, 2023 •

edited

Loading

codecov bot commented Nov 15, 2023 •

edited

Loading