Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/param: add correct fsp for duration #48564

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #48563

Problem Summary:

The TIME parameters will always use us precision.

What is changed and how it works?

Only use us (6) precision when the parameter length is 12.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Fix the issue that the `TIME` parameters always use the `us` precision.

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #48564 (b931162) into master (6e8df18) will increase coverage by 1.4599%.
Report is 8 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48564        +/-   ##
================================================
+ Coverage   71.4008%   72.8607%   +1.4599%     
================================================
  Files          1403       1428        +25     
  Lines        406991     414043      +7052     
================================================
+ Hits         290595     301675     +11080     
+ Misses        96441      93436      -3005     
+ Partials      19955      18932      -1023     
Flag Coverage Δ
integration 43.2978% <0.0000%> (?)
unit 71.4758% <ø> (+0.0750%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8330% <ø> (-4.2341%) ⬇️

@YangKeao
Copy link
Member Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2023
Copy link

ti-chi-bot bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2023
Copy link

ti-chi-bot bot commented Nov 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-14 01:47:22.659160812 +0000 UTC m=+4127240.246270957: ☑️ agreed by xhebox.
  • 2023-11-14 06:41:34.36863345 +0000 UTC m=+4144891.955743597: ☑️ agreed by lcwangchao.

@ti-chi-bot ti-chi-bot bot merged commit 4793a04 into pingcap:master Nov 14, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duration parameters don't have correct fsp
3 participants