Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: control the snapshots batch size for fsr enable/disable (#48506) #48525

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48506

What problem does this PR solve?

Issue Number: close #48505

Problem Summary:

What is changed and how it works?

This PR will control the batch size of snapshots for AWS snapshot FSR enablement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 11, 2023
@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@61e5beb). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #48525   +/-   ##
================================================
  Coverage               ?   73.6448%           
================================================
  Files                  ?       1085           
  Lines                  ?     348899           
  Branches               ?          0           
================================================
  Hits                   ?     256946           
  Misses                 ?      75478           
  Partials               ?      16475           

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 11, 2023
Copy link

ti-chi-bot bot commented Nov 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2023
Copy link

ti-chi-bot bot commented Nov 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-11 09:11:52.038859611 +0000 UTC m=+3894709.625969741: ☑️ agreed by BornChanger.
  • 2023-11-11 09:23:55.270175528 +0000 UTC m=+3895432.857285673: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit cf8dbc2 into pingcap:release-6.5 Nov 11, 2023
28 checks passed
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants