parser/executor: admin show/set bdr role #48504

okJiang · 2023-11-10T02:14:57Z

What problem does this PR solve?

Issue Number: ref #48519

Problem Summary:

What is changed and how it works?

admin show bdr role
admin set bdr role none/primary/secondary/local_only

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2023-11-10T02:15:00Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2023-11-10T02:15:05Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

okJiang · 2023-11-10T07:45:33Z

/ok-to-test

tests/integrationtest/t/executor/executor.test

Co-authored-by: tangenta <tangenta@126.com>

codecov · 2023-11-10T08:01:46Z

Codecov Report

Merging #48504 (172a4d4) into master (15f7b6e) will increase coverage by 1.7995%.
Report is 4 commits behind head on master.
The diff coverage is 82.5396%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #48504        +/-   ##
================================================
+ Coverage   71.2233%   73.0229%   +1.7995%     
================================================
  Files          1360       1384        +24     
  Lines        403758     412906      +9148     
================================================
+ Hits         287570     301516     +13946     
+ Misses        96260      92599      -3661     
+ Partials      19928      18791      -1137

Flag	Coverage Δ
integration	`43.8184% <81.6326%> (?)`
unit	`71.5983% <28.5714%> (+0.3749%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9874% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.9001% <ø> (-4.1622%)`	⬇️

okJiang · 2023-11-13T02:58:09Z

ping @tangenta @GMHDBJD

okJiang · 2023-11-14T07:33:08Z

/retest

okJiang · 2023-11-14T08:08:19Z

/retest

ywqzzy · 2023-11-15T01:52:42Z

pkg/parser/parser.y

@@ -6525,6 +6529,7 @@ UnReservedKeyword:
 |	"AFTER"
 |	"ALWAYS"
 |	"AVG"
+|   "BDR"


more indent？

fixed in bd24d72

ywqzzy · 2023-11-15T01:52:48Z

pkg/parser/parser.y

@@ -6582,6 +6587,7 @@ UnReservedKeyword:
 |	"INSERT_METHOD"
 |	"LESS"
 |	"LOCAL"
+|   "LOCAL_ONLY"


okJiang · 2023-11-16T08:04:48Z

/test tiprow_fast_test

ti-chi-bot · 2023-11-16T08:04:52Z

@okJiang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/canary_ghpr_unit_test
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GMHDBJD

LGTM

ti-chi-bot · 2023-11-16T08:07:45Z

[LGTM Timeline notifier]

Timeline:

2023-11-14 06:34:02.629342044 +0000 UTC m=+4144440.216452189: ☑️ agreed by tangenta.
2023-11-16 08:07:43.861339548 +0000 UTC m=+4322861.448449693: ☑️ agreed by GMHDBJD.

okJiang · 2023-11-16T09:53:19Z

/retest

easonn7 · 2023-11-16T10:05:00Z

/approve

ti-chi-bot · 2023-11-16T10:05:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, GMHDBJD, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,tangenta]
~~pkg/meta/OWNERS~~ [GMHDBJD,tangenta]
~~pkg/parser/OWNERS~~ [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

okJiang · 2023-11-16T11:26:28Z

/retest

okJiang added 4 commits November 6, 2023 18:04

save work

2e7096e

complete parser

ddbb3e1

implement executor

23e0199

implement "admin show bdr role"

f7eb0b4

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 10, 2023

ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 10, 2023

okJiang added 3 commits November 10, 2023 11:25

add ut

49c020b

Merge branch 'master' of https://github.com/pingcap/tidb into bdr-role

0e953f9

add integration test

0e0a319

okJiang mentioned this pull request Nov 10, 2023

Support executing DDL when cluster is in BDR mode #48519

Closed

6 tasks

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Nov 10, 2023

okJiang changed the title ~~[wip]parser/executor: bdr role~~ parser/executor: admin show/set bdr role Nov 10, 2023

okJiang marked this pull request as ready for review November 10, 2023 07:45

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 10, 2023

tangenta reviewed Nov 10, 2023

View reviewed changes

tests/integrationtest/t/executor/executor.test Outdated Show resolved Hide resolved

Update tests/integrationtest/t/executor/executor.test

580d62e

Co-authored-by: tangenta <tangenta@126.com>

okJiang added 2 commits November 10, 2023 16:43

fix bazel

64df011

Merge branch 'bdr-role' of https://github.com/okJiang/tidb into bdr-role

b72e0a9

okJiang added 2 commits November 14, 2023 14:23

fix bazel

0394219

add comment

0f31731

tangenta approved these changes Nov 14, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 14, 2023

ywqzzy reviewed Nov 15, 2023

View reviewed changes

okJiang added 2 commits November 16, 2023 15:18

fix comment

bd24d72

Merge branch 'master' of https://github.com/pingcap/tidb into bdr-role

172a4d4

GMHDBJD approved these changes Nov 16, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 16, 2023

ti-chi-bot bot added the approved label Nov 16, 2023

ti-chi-bot bot merged commit bee2876 into pingcap:master Nov 16, 2023
16 checks passed

okJiang deleted the bdr-role branch November 21, 2023 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

parser/executor: admin show/set bdr role #48504

parser/executor: admin show/set bdr role #48504

okJiang commented Nov 10, 2023 •

edited

Loading

ti-chi-bot bot commented Nov 10, 2023

tiprow bot commented Nov 10, 2023

okJiang commented Nov 10, 2023

codecov bot commented Nov 10, 2023 •

edited

Loading

okJiang commented Nov 13, 2023

okJiang commented Nov 14, 2023

okJiang commented Nov 14, 2023

ywqzzy Nov 15, 2023

okJiang Nov 16, 2023

ywqzzy Nov 15, 2023

okJiang commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

GMHDBJD left a comment

ti-chi-bot bot commented Nov 16, 2023

okJiang commented Nov 16, 2023

easonn7 commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

okJiang commented Nov 16, 2023

parser/executor: admin show/set bdr role #48504

parser/executor: admin show/set bdr role #48504

Conversation

okJiang commented Nov 10, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Nov 10, 2023

tiprow bot commented Nov 10, 2023

okJiang commented Nov 10, 2023

codecov bot commented Nov 10, 2023 • edited Loading

Codecov Report

okJiang commented Nov 13, 2023

okJiang commented Nov 14, 2023

okJiang commented Nov 14, 2023

ywqzzy Nov 15, 2023

Choose a reason for hiding this comment

okJiang Nov 16, 2023

Choose a reason for hiding this comment

ywqzzy Nov 15, 2023

Choose a reason for hiding this comment

okJiang commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

GMHDBJD left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

okJiang commented Nov 16, 2023

easonn7 commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

okJiang commented Nov 16, 2023

okJiang commented Nov 10, 2023 •

edited

Loading

codecov bot commented Nov 10, 2023 •

edited

Loading