-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: use memory available as the memory limit for add index #48268
Conversation
Hi @GMHDBJD. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: tangenta <tangenta@126.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48268 +/- ##
================================================
+ Coverage 71.4846% 75.9783% +4.4936%
================================================
Files 1402 1442 +40
Lines 406266 446155 +39889
================================================
+ Hits 290418 338981 +48563
+ Misses 96008 88706 -7302
+ Partials 19840 18468 -1372
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/ddl/backfilling_operators.go
Outdated
return nil, err | ||
} | ||
memAvailable := memTotal - memUsed | ||
logutil.BgLogger().Info("build operators that write index to cloud storage", zap.Uint64("memory total", memTotal), zap.Uint64("memory used", memUsed), zap.Uint64("memory available", memAvailable)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logutil.BgLogger().Info("build operators that write index to cloud storage", zap.Uint64("memory total", memTotal), zap.Uint64("memory used", memUsed), zap.Uint64("memory available", memAvailable)) | |
logutil.BgLogger().Info("build operators that write index to cloud storage", zap.Uint64("memory total", memTotal), zap.Uint64("memory used", memUsed), zap.Uint64("buffer size", memSize)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
1 similar comment
/retest |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #47757
Problem Summary:
What is changed and how it works?
Check List
Tests
add index, check the log
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.