Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: use memory available as the memory limit for add index #48268

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Nov 3, 2023

What problem does this PR solve?

Issue Number: ref #47757

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    add index, check the log
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. do-not-merge/invalid-title do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2023
Copy link

tiprow bot commented Nov 3, 2023

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GMHDBJD GMHDBJD changed the title use memory available as the mermory limit for add index addIndex: use memory available as the mermory limit for add index Nov 3, 2023
GMHDBJD and others added 2 commits November 3, 2023 14:00
Co-authored-by: tangenta <tangenta@126.com>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #48268 (1c5c41e) into master (0172ba0) will increase coverage by 4.4936%.
Report is 155 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48268        +/-   ##
================================================
+ Coverage   71.4846%   75.9783%   +4.4936%     
================================================
  Files          1402       1442        +40     
  Lines        406266     446155     +39889     
================================================
+ Hits         290418     338981     +48563     
+ Misses        96008      88706      -7302     
+ Partials      19840      18468      -1372     
Flag Coverage Δ
integration 47.5438% <0.0000%> (?)
unit 74.6727% <0.0000%> (+3.1880%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1220% <ø> (+0.1345%) ⬆️
parser ∅ <ø> (∅)
br 49.7814% <ø> (-3.1462%) ⬇️

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 3, 2023

/retest

Copy link

tiprow bot commented Nov 3, 2023

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta tangenta changed the title addIndex: use memory available as the mermory limit for add index ddl: use memory available as the mermory limit for add index Nov 3, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 3, 2023
return nil, err
}
memAvailable := memTotal - memUsed
logutil.BgLogger().Info("build operators that write index to cloud storage", zap.Uint64("memory total", memTotal), zap.Uint64("memory used", memUsed), zap.Uint64("memory available", memAvailable))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logutil.BgLogger().Info("build operators that write index to cloud storage", zap.Uint64("memory total", memTotal), zap.Uint64("memory used", memUsed), zap.Uint64("memory available", memAvailable))
logutil.BgLogger().Info("build operators that write index to cloud storage", zap.Uint64("memory total", memTotal), zap.Uint64("memory used", memUsed), zap.Uint64("buffer size", memSize))

@tangenta tangenta changed the title ddl: use memory available as the mermory limit for add index ddl: use memory available as the memory limit for add index Nov 6, 2023
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2023
Copy link

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-03 08:07:33.636607144 +0000 UTC m=+3199651.223717274: ☑️ agreed by tangenta.
  • 2023-11-13 02:20:11.787282338 +0000 UTC m=+4042809.374392483: ☑️ agreed by zimulala.

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit a49630b into pingcap:master Nov 22, 2023
13 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48818.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants