Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: move IT in executor to tests/integrationtest (PART 10) #48263

Merged
merged 6 commits into from
Nov 6, 2023
Merged

tests: move IT in executor to tests/integrationtest (PART 10) #48263

merged 6 commits into from
Nov 6, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #47076

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2023
@tiprow tiprow
Copy link

tiprow bot commented Nov 3, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Merging #48263 (42c8e10) into master (d99c5a5) will increase coverage by 1.4673%.
Report is 13 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48263        +/-   ##
================================================
+ Coverage   71.4915%   72.9589%   +1.4673%     
================================================
  Files          1402       1425        +23     
  Lines        406217     413634      +7417     
================================================
+ Hits         290411     301783     +11372     
+ Misses        95973      92992      -2981     
+ Partials      19833      18859       -974
Flag Coverage Δ
integration 43.1226% <ø> (?)
unit 71.5890% <ø> (+0.0974%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 49.0021% <ø> (-3.9235%) ⬇️

@Defined2014
Copy link
Contributor Author

@hawkingrei @YangKeao @SeaRise PTAL

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 4, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2023
SeaRise
SeaRise approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/integrationtest/t/executor/jointest/join.test
CREATE TABLE t1(a INT);
CREATE TABLE t2 (d BINARY(2), PRIMARY KEY (d(1)), UNIQUE KEY (d));
INSERT INTO t1 values(1);
SELECT 1 FROM executor__jointest__join.t1, executor__jointest__join.t2 WHERE 1 = (SELECT executor__jointest__join.t2.d FROM executor__jointest__join.t2 WHERE executor__jointest__join.t1.a >= 1) and executor__jointest__join.t2.d = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SELECT 1 FROM executor__jointest__join.t1, executor__jointest__join.t2 WHERE 1 = (SELECT executor__jointest__join.t2.d FROM executor__jointest__join.t2 WHERE executor__jointest__join.t1.a >= 1) and executor__jointest__join.t2.d = 1;
SELECT 1 FROM t1, t2 WHERE 1 = (SELECT t2.d FROM t2 WHERE t1.a >= 1) and t2.d = 1;

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-04 11:44:15.979764172 +0000 UTC m=+3299053.566874317: ☑️ agreed by hawkingrei.
  • 2023-11-06 01:42:33.172482492 +0000 UTC m=+3435750.759592637: ☑️ agreed by SeaRise.

@SeaRise
Copy link
Contributor

SeaRise commented Nov 6, 2023

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2165ca5 into pingcap:master Nov 6, 2023
14 of 16 checks passed
@Defined2014 Defined2014 deleted the move-executor-part10 branch November 14, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@SeaRise SeaRise SeaRise approved these changes

@YangKeao YangKeao Awaiting requested review from YangKeao

Assignees
No one assigned
Labels
approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Defined2014 @hawkingrei @SeaRise