Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: make TestHalfwayCancelOperations faster #48251

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Nov 2, 2023

What problem does this PR solve?

Issue Number: close #46840

Problem Summary:
When we occur exchangePartitionErr, we will retry 512 times.

What is changed and how it works?

Set DDLErrorCountLimit to 3.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Before this PR
without race

PASS
ok  	github.com/pingcap/tidb/pkg/ddl/tests/fail	2.762s

with race

PASS
ok  	github.com/pingcap/tidb/pkg/ddl/tests/fail	10.506s

After this PR
without race

PASS
ok  	github.com/pingcap/tidb/pkg/ddl/tests/fail	2.068s

with race

PASS
ok  	github.com/pingcap/tidb/pkg/ddl/tests/fail	5.072s
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2023
Copy link

tiprow bot commented Nov 2, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #48251 (529f933) into master (eed2a76) will increase coverage by 1.3865%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48251        +/-   ##
================================================
+ Coverage   71.4958%   72.8824%   +1.3865%     
================================================
  Files          1402       1425        +23     
  Lines        406166     413183      +7017     
================================================
+ Hits         290392     301138     +10746     
+ Misses        95949      93156      -2793     
+ Partials      19825      18889       -936     
Flag Coverage Δ
integration 42.7789% <ø> (?)
unit 71.5782% <ø> (+0.0823%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6961% <ø> (-4.2338%) ⬇️

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 3, 2023
Copy link

ti-chi-bot bot commented Nov 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-02 15:42:15.481126669 +0000 UTC m=+3140533.068236814: ☑️ agreed by hawkingrei.
  • 2023-11-03 02:03:08.461146783 +0000 UTC m=+3177786.048256927: ☑️ agreed by Defined2014.

Copy link

ti-chi-bot bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 3, 2023
@zimulala
Copy link
Contributor Author

zimulala commented Nov 3, 2023

/retest-required

Copy link

tiprow bot commented Nov 3, 2023

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Nov 3, 2023

@zimulala: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 529f933 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zimulala
Copy link
Contributor Author

zimulala commented Nov 3, 2023

/retest-required

Copy link

tiprow bot commented Nov 3, 2023

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit 0cca59f into pingcap:master Nov 3, 2023
14 of 16 checks passed
@zimulala zimulala deleted the zimuxia/make-test-fast branch February 23, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/test lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slow test TestHalfwayCancelOperations in ddl/tests/fail pkg
4 participants