-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: make TestHalfwayCancelOperations faster #48251
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48251 +/- ##
================================================
+ Coverage 71.4958% 72.8824% +1.3865%
================================================
Files 1402 1425 +23
Lines 406166 413183 +7017
================================================
+ Hits 290392 301138 +10746
+ Misses 95949 93156 -2793
+ Partials 19825 18889 -936
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/check-issue-triage-complete |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@zimulala: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-issue-triage-complete |
What problem does this PR solve?
Issue Number: close #46840
Problem Summary:
When we occur
exchangePartitionErr
, we will retry 512 times.What is changed and how it works?
Set
DDLErrorCountLimit
to 3.Check List
Tests
Before this PR
without race
with race
After this PR
without race
with race
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.