Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix TestSupportedSuffixForServerDisk when in RBE #48249

Merged
merged 12 commits into from
Nov 3, 2023
Merged

*: fix TestSupportedSuffixForServerDisk when in RBE #48249

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a8336cd
update
hawkingrei Nov 2, 2023
1b8810f
update
hawkingrei Nov 2, 2023
da393d4
update
hawkingrei Nov 2, 2023
b3f6800
*: update tools
hawkingrei Nov 2, 2023
89f3cd7
*: update tools
hawkingrei Nov 2, 2023
50ed90f
*: update tools
hawkingrei Nov 2, 2023
b8857fd
parser: avoid using too new syntax features
hawkingrei Nov 2, 2023
29cc3b6
parser: avoid using too new syntax features
hawkingrei Nov 2, 2023
f2f3dcc
update
hawkingrei Nov 2, 2023
9920920
update
hawkingrei Nov 2, 2023
1895dba
update
hawkingrei Nov 2, 2023
ceb3f1b
update
hawkingrei Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/executor/importer/import_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"fmt"
"net/url"
"os"
"os/user"
"path"
"path/filepath"
"runtime"
Expand Down Expand Up @@ -308,6 +309,11 @@ func TestGetBackendWorkerConcurrency(t *testing.T) {
}

func TestSupportedSuffixForServerDisk(t *testing.T) {
username, err := user.Current()
require.NoError(t, err)
if username.Name == "root" {
t.Skip("it cannot run as root")
}
tempDir := t.TempDir()
ctx := context.Background()

Expand Down Expand Up @@ -363,7 +369,7 @@ func TestSupportedSuffixForServerDisk(t *testing.T) {
require.ErrorContains(t, err2, "URI of data source is invalid")
// non-exist parent directory
c.Path = "/path/to/non/exists/file.csv"
err := c.InitDataFiles(ctx)
err = c.InitDataFiles(ctx)
require.ErrorIs(t, err, exeerrors.ErrLoadDataInvalidURI)
require.ErrorContains(t, err, "no such file or directory")
// without permission to parent dir
Expand Down