Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: update client-go to fix #35418 (#47951) #48101

Merged
merged 2 commits into from
Oct 30, 2023
Merged

executor: update client-go to fix #35418 (#47951) #48101

merged 2 commits into from
Oct 30, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47951

What problem does this PR solve?

Issue Number: close #35418

Problem Summary:

What is changed and how it works?

update client-go to fix #35418

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • tests added in client-go side

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the bug that TiFlash load may not be balanced if some TiFlash nodes is back to up after down for a long time.

@windtalker @ti-chi-bot
update client-go
975852c 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker @ti-chi-bot
fix ci
c54ab23 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 30, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 30, 2023
@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei requested a review from you06 October 30, 2023 14:05
@you06
Copy link
Contributor

you06 commented Oct 30, 2023

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 10:11:30.753619655 +0000 UTC m=+2861488.340729800: ☑️ agreed by hawkingrei.
  • 2023-10-30 15:07:15.417027475 +0000 UTC m=+2879233.004137605: ☑️ agreed by you06.

@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 57d7775 into pingcap:release-7.5 Oct 30, 2023
7 checks passed
rleungx pushed a commit to rleungx/tidb that referenced this pull request Feb 26, 2024
@iosmanthus
bump client-go and cse-region-client to release-7.5 (pingcap#782)
767529e 
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
fix pingcap#35418 (pingcap#47951) (pingcap#48101)
close pingcap#35418
close tikv/pd#7509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@you06 you06 you06 approved these changes

Assignees

@hawkingrei hawkingrei

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @hawkingrei @you06 @windtalker