Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Ignore *.log.json files, like tidb-audit.log.json #48043

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 27, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@dveeden dveeden added the skip-issue-check Indicates that a PR no need to check linked issue. label Oct 27, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2023
@tiprow
Copy link

tiprow bot commented Oct 27, 2023

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor Author

dveeden commented Oct 27, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #48043 (43a810e) into master (3d353f1) will increase coverage by 1.2776%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48043        +/-   ##
================================================
+ Coverage   71.6345%   72.9121%   +1.2776%     
================================================
  Files          1401       1424        +23     
  Lines        405747     413931      +8184     
================================================
+ Hits         290655     301806     +11151     
+ Misses        95311      93240      -2071     
+ Partials      19781      18885       -896     
Flag Coverage Δ
integration 42.3477% <ø> (?)
unit 71.7937% <ø> (+0.1591%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0503% <ø> (+0.0589%) ⬆️
parser ∅ <ø> (∅)
br 48.4856% <ø> (-4.5634%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2023
@tiprow
Copy link

tiprow bot commented Oct 27, 2023

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 43a810e link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-27 12:39:18.351047804 +0000 UTC m=+2611155.938157949: ☑️ agreed by CbcWestwolf.
  • 2023-10-28 04:33:19.463767276 +0000 UTC m=+2668397.050877421: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 3682bd8 into pingcap:master Oct 28, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants