Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix typo #48039

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: None

Problem Summary:

What is changed and how it works?

Fixed a typo.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@Rustin170506 Rustin170506 added the skip-issue-check Indicates that a PR no need to check linked issue. label Oct 27, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-27 07:22:02.186937456 +0000 UTC m=+2592119.774047596: ☑️ agreed by AilinKid.
  • 2023-10-27 07:22:14.194199804 +0000 UTC m=+2592131.781309947: ☑️ agreed by qw4990.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #48039 (c866996) into master (a51ea16) will increase coverage by 1.3883%.
Report is 9 commits behind head on master.
The diff coverage is 80.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48039        +/-   ##
================================================
+ Coverage   71.6425%   73.0308%   +1.3883%     
================================================
  Files          1401       1424        +23     
  Lines        405738     413936      +8198     
================================================
+ Hits         290681     302301     +11620     
+ Misses        95280      92769      -2511     
+ Partials      19777      18866       -911     
Flag Coverage Δ
integration 42.3546% <0.0000%> (?)
unit 71.8678% <80.0000%> (+0.2253%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0503% <ø> (+0.0589%) ⬆️
parser ∅ <ø> (∅)
br 49.2104% <ø> (-3.8366%) ⬇️

@Rustin170506
Copy link
Member Author

/retest

2 similar comments
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9f88af5 into pingcap:master Oct 27, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants