disttask: fix removing meta when met network partition for so long then recover from it (#48005) #48024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note
Merged
13 tasks
ti-chi-bot
added
the
cherry-pick-approved
ywqzzy
approved these changes
Oct 27, 2023
tangenta
approved these changes
Oct 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #48005
What problem does this PR solve?
Issue Number: close #47954
Problem Summary:
When a prolonged encounter network partition, the dist task framework may have chance to remove meta for the tidb node.
When the tidb node recovers from the network partition, the meta loss.
Then dispatcher may has chance to detect no available nodes to dispatch subtasks.
What is changed and how it works?
Add recoverMetaLoop which inits and recovers dist_framework_meta for the tidb node running the scheduler manager.
This is necessary when the TiDB node experiences a prolonged network partition and the dispatcher deletes
dist_framework_meta. When the TiDB node recovers from the network partition, we need to re-insert the metadata.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.