Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix panic in pause #47914

Merged
merged 1 commit into from
Oct 23, 2023
Merged

ddl: fix panic in pause #47914

merged 1 commit into from
Oct 23, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Oct 23, 2023

What problem does this PR solve?

Issue Number: close #47902

Problem Summary:
reorgCtx for reorgJob is cleaned up since worker is closed when calling isReorgPaused.

What is changed and how it works?

Use isReorgRunnable to ignore the check.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2023
@tiprow
Copy link

tiprow bot commented Oct 23, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #47914 (4e0cce7) into master (aa453de) will increase coverage by 1.0344%.
Report is 33 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47914        +/-   ##
================================================
+ Coverage   71.8945%   72.9289%   +1.0344%     
================================================
  Files          1398       1423        +25     
  Lines        405142     412644      +7502     
================================================
+ Hits         291275     300937      +9662     
+ Misses        94250      92875      -1375     
+ Partials      19617      18832       -785     
Flag Coverage Δ
integration 41.9908% <0.0000%> (?)
unit 71.8796% <0.0000%> (-0.0149%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.9495% <ø> (-3.9918%) ⬇️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 23, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 23, 2023

/cc @zimulala

@ti-chi-bot ti-chi-bot bot requested a review from zimulala October 23, 2023 06:26
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-23 06:04:33.590747536 +0000 UTC m=+2241871.177857681: ☑️ agreed by tangenta.
  • 2023-10-23 07:42:32.838368475 +0000 UTC m=+2247750.425478621: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit b584055 into pingcap:master Oct 23, 2023
12 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #47933.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 23, 2023
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add index status was always running, tidb panic and can not start when tidb rolling restart
5 participants