Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix path of LDFLAGS for global kill e2e test #47896

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Oct 21, 2023

What problem does this PR solve?

Issue Number: close #47895

Problem Summary: Global kill e2e test failed

What is changed and how it works?

Fix path of LDFLAGS related to path changed by #47123.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2023
@tiprow
Copy link

tiprow bot commented Oct 21, 2023

Hi @pingyu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingyu
Copy link
Contributor Author

pingyu commented Oct 21, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 21, 2023
@pingyu
Copy link
Contributor Author

pingyu commented Oct 21, 2023

/test pull-e2e-test

@tiprow
Copy link

tiprow bot commented Oct 21, 2023

@pingyu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #47896 (adfbd25) into master (012869f) will increase coverage by 0.9438%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47896        +/-   ##
================================================
+ Coverage   71.8595%   72.8033%   +0.9438%     
================================================
  Files          1399       1422        +23     
  Lines        405473     411849      +6376     
================================================
+ Hits         291371     299840      +8469     
+ Misses        94446      93142      -1304     
+ Partials      19656      18867       -789     
Flag Coverage Δ
integration 41.7578% <ø> (?)
unit 71.8617% <ø> (+0.0022%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6971% <ø> (-4.2685%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2023
@hawkingrei hawkingrei added affects-7.5 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Oct 21, 2023
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-21 05:28:14.696584096 +0000 UTC m=+2066892.283694236: ☑️ agreed by hawkingrei.
  • 2023-10-21 13:16:44.10321541 +0000 UTC m=+2095001.690325547: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit c0364e5 into pingcap:master Oct 21, 2023
16 of 17 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #47898.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global kill e2e test failed
4 participants