Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix delete range drop indices not entirely #47827

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 20, 2023

What problem does this PR solve?

Issue Number: close #47825

Problem Summary:
delete range drop indices not entirely

What is changed and how it works?

drop all the indices if they are global.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2023
@tiprow
Copy link

tiprow bot commented Oct 20, 2023

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #47827 (96fd4bf) into master (f4a139f) will increase coverage by 1.0623%.
Report is 12 commits behind head on master.
The diff coverage is 25.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47827        +/-   ##
================================================
+ Coverage   71.8610%   72.9233%   +1.0623%     
================================================
  Files          1398       1423        +25     
  Lines        405256     413042      +7786     
================================================
+ Hits         291221     301204      +9983     
+ Misses        94397      92992      -1405     
+ Partials      19638      18846       -792     
Flag Coverage Δ
integration 41.8191% <25.0000%> (?)
unit 71.9915% <25.0000%> (+0.1305%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7349% <ø> (-4.2327%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2023
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for it?

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 20, 2023

Could you add a test for it?

There seems no SQL case triggering this error... And there is no smaller granularity test.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 03:17:56.878180812 +0000 UTC m=+1972674.465290956: ☑️ agreed by tangenta.
  • 2023-10-20 08:06:44.622390267 +0000 UTC m=+1990002.209500413: ☑️ agreed by zimulala.

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 20, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit b920362 into pingcap:master Oct 20, 2023
13 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #47888.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete range drop indices not entirely
4 participants