pkg/ddl: fix an issue where endkey usage issues caused index loss

[zimulala]

What problem does this PR solve?

Issue Number: close #46306

Problem Summary:
Ref: #45679. Before this PR(#45679 ), we used [startKey, endKey] with endInclude as the table range. After this PR we used [startKey, endKey.next).
We do "add index" on a branch without #45679, then get startKey and endKey with the range [startKey, endKey].
Then we do upgrade, we will continue to "add index" in the branch with #45679. And we use [startKey, endKey).

What is changed and how it works?

If the old version upgrades to the new version, we add Next to the endKey.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

deploy v7.1.1+ cluster
set @@global.tidb_ddl_enable_fast_reorg = 0;
Create a table and import 3.5 million rows.

Do alter table t add index idx(a, b);, and when it backfills 700,000+ indexes, kill the cluster.
Then upgrade this cluster to master.
After upgrading successfully, do admin check index t idx

Result:

• Before this PR, we will get an error like ERROR 8223 (HY000): data inconsistency in table: t, index: idx, handle: 3572562, index-values:"" != record-values:"handle: 3572562, values: [KindString 131 KindString xxx]"
• After this PR, we get Query OK.

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #47818 (0a25f53) into master (ab4c20b) will increase coverage by 0.9081%.
Report is 39 commits behind head on master.
The diff coverage is 20.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47818        +/-   ##
================================================
+ Coverage   71.8756%   72.7837%   +0.9081%     
================================================
  Files          1396       1422        +26     
  Lines        404969     411710      +6741     
================================================
+ Hits         291074     299658      +8584     
+ Misses        94275      93185      -1090     
+ Partials      19620      18867       -753     

Flag	Coverage Δ
integration	41.4691% <20.0000%> (?)
unit	71.8479% <20.0000%> (-0.0278%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9913% <ø> (ø)
parser	∅ <ø> (∅)
br	48.6737% <ø> (-4.2782%)	⬇️

[zimulala]

/test check-dev2

[tiprow]

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-10-20 06:24:48.27126197 +0000 UTC m=+1983885.858372100: ☑️ agreed by tangenta.
• 2023-10-20 08:30:45.339350338 +0000 UTC m=+1991442.926460468: ☑️ agreed by wjhuang2016.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #47884.