Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, tests: move test cases from executor to integrationtest (PART 3) #47796

Merged
merged 4 commits into from
Oct 21, 2023
Merged

executor, tests: move test cases from executor to integrationtest (PART 3) #47796

merged 4 commits into from
Oct 21, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #47076

Problem Summary: update compact_table, adapter, cte, explain, explainfor, grant. Total case number is 55.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014
update cluster_table
7d36f9b 
update compact_table

update adapter

update cte

update explain

update explainfor

update grant
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 19, 2023
@tiprow
Copy link

tiprow bot commented Oct 19, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #47796 (dbbbe10) into master (6166594) will increase coverage by 1.1100%.
Report is 20 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47796        +/-   ##
================================================
+ Coverage   71.8642%   72.9743%   +1.1100%     
================================================
  Files          1398       1422        +24     
  Lines        405200     413444      +8244     
================================================
+ Hits         291194     301708     +10514     
+ Misses        94374      92873      -1501     
+ Partials      19632      18863       -769
Flag Coverage Δ
integration 41.9520% <ø> (?)
unit 71.9825% <ø> (+0.1183%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7533% <ø> (-4.1841%) ⬇️

SeaRise
SeaRise reviewed Oct 20, 2023
View reviewed changes
tests/integrationtest/t/executor/adapter.test Show resolved Hide resolved
tests/integrationtest/t/executor/grant.test Outdated Show resolved Hide resolved
tests/integrationtest/t/executor/grant.test
set sql_mode=default;

# TestCreateUserWithTooLongName
-- error 1470
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to drop user first? Will this test be run repeatedly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop user will report error, the user name is too long.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

tests/integrationtest/t/executor/explainfor.test Show resolved Hide resolved
tests/integrationtest/t/executor/cte.test Show resolved Hide resolved
tests/integrationtest/t/executor/cluster_table.test Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 08:55:27.771405255 +0000 UTC m=+1992925.358515400: ☑️ agreed by SeaRise.
  • 2023-10-21 06:47:27.624564833 +0000 UTC m=+2071645.211674978: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3f9ba2b into pingcap:master Oct 21, 2023
15 of 16 checks passed
@Defined2014 Defined2014 deleted the move-executor-part3 branch November 14, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@SeaRise SeaRise SeaRise approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@YangKeao YangKeao Awaiting requested review from YangKeao

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Defined2014 @hawkingrei @SeaRise