Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: smaller task channel when to merge global stats #47761

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 18, 2023

What problem does this PR solve?

Issue Number: close #47762

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Oct 18, 2023
@hawkingrei hawkingrei requested a review from winoros October 18, 2023 14:23
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #47761 (42edc82) into master (ac1f0d9) will increase coverage by 0.8938%.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47761        +/-   ##
================================================
+ Coverage   71.8931%   72.7869%   +0.8938%     
================================================
  Files          1398       1421        +23     
  Lines        405200     411575      +6375     
================================================
+ Hits         291311     299573      +8262     
+ Misses        94269      93151      -1118     
+ Partials      19620      18851       -769     
Flag Coverage Δ
integration 41.3384% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6682% <ø> (-4.2653%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 14:29:54.205039275 +0000 UTC m=+1840191.792149412: ☑️ agreed by chrysan.
  • 2023-10-18 15:00:46.358181075 +0000 UTC m=+1842043.945291220: ☑️ agreed by winoros.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the smaller_topn_channel branch from 05cd40e to 42edc82 Compare October 18, 2023 15:08
@tiprow
Copy link

tiprow bot commented Oct 18, 2023

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 42edc82 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit ab32fc7 into pingcap:master Oct 18, 2023
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@hawkingrei hawkingrei deleted the smaller_topn_channel branch October 19, 2023 13:39
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #47813.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 19, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use too much memory when to merge topn/hists stats
4 participants