statistics: fix auto analyze for global index

[L-maple]

What problem does this PR solve?

Issue Number: close #47539

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Hi @L-maple. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @L-maple. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hawkingrei]

/ok-to-test

[codecov]

Codecov Report

Merging #47754 (67b89bc) into master (18979c6) will increase coverage by 1.3715%.
Report is 1402 commits behind head on master.
The diff coverage is 29.2682%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47754        +/-   ##
================================================
+ Coverage   71.4161%   72.7877%   +1.3715%     
================================================
  Files          1402       1425        +23     
  Lines        406373     412792      +6419     
================================================
+ Hits         290216     300462     +10246     
+ Misses        96261      93406      -2855     
+ Partials      19896      18924       -972     

Flag	Coverage Δ
integration	42.9595% <29.2682%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9874% <ø> (ø)
parser	∅ <ø> (∅)
br	48.6730% <ø> (-4.2509%)	⬇️

[qw4990]

@hawkingrei PTAL

[hawkingrei]

/test all

[hawkingrei]

@L-maple Please run make bazel_prepare to update bazel config.

[hawkingrei]

/retest

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-10-31 13:57:42.762286088 +0000 UTC m=+2961460.349396233: ☑️ agreed by hawkingrei.

[winoros]

/hold for a while for some discussion

[winoros]

@L-maple, I think the changes in this pull will make the global index's statistics collecting a separate process from the merging global stats?

[L-maple]

@L-maple, I think the changes in this pull will make the global index's statistics collecting a separate process from the merging global stats?

@winoros Thanks, I revise the PR again for merging global stats compatibility.
in handleGlobalStats, if results.TableID.IsPartitionTable() && needGlobalStats { will check the global index is not needed to be merged.

[L-maple]

@winoros Hi, do you have any other advice？This PR can be reiviewed again.

[winoros]

@winoros Hi, do you have any other advice？This PR can be reiviewed again.

It needs some time to discuss the behavior. How could I reach you via some IM?

[L-maple]

Thanks for your feedback，my wechat ID is：lcj960929（刘常杰） Maybe I should add some comments for global index statistics in the code.

…

---- Replied Message ---- | From | Yiding ***@***.***> | | Date | 11/13/2023 22:47 | | To | ***@***.***> | | Cc | Changjie ***@***.***>***@***.***> | | Subject | Re: [pingcap/tidb] statistics: fix auto analyze for global index (PR #47754) | @winoros Hi, do you have any other advice？This PR can be reiviewed again. It needs some time to discuss the behavior. How could I reach you via some IM? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

@L-maple: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	67b89bc	link	true	/test build
idc-jenkins-ci-tidb/check_dev	67b89bc	link	true	/test check-dev
idc-jenkins-ci-tidb/mysql-test	67b89bc	link	true	/test mysql-test
idc-jenkins-ci-tidb/check_dev_2	67b89bc	link	true	/test check-dev2
idc-jenkins-ci-tidb/unit-test	67b89bc	link	true	/test unit-test
pull-integration-ddl-test	67b89bc	link	true	/test pull-integration-ddl-test
pull-mysql-client-test	67b89bc	link	true	/test pull-mysql-client-test
pull-br-integration-test	67b89bc	link	true	/test pull-br-integration-test
pull-lightning-integration-test	67b89bc	link	true	/test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.