Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: do not convert update to point get if the expr has sub-query (#47454) #47736

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47454

What problem does this PR solve?

Issue Number: close #47445

Problem Summary:

What is changed and how it works?

  • do not convert update to point get if the expr has sub-query
    • covered the case expr
    • covered the parentheses case expr
    • covered the parentheses sub-query expr
    • covered the sub-query expr (do we really need this? I copied the code from the old code)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed TiDB incorrectly converts update statement to point get plan issue

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 18, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 20, 2023
Comment on lines 1167 to 1168
<<<<<<< HEAD:planner/core/plan_test.go
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the conflict? we need this go to 6.5

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@49d93b8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #47736   +/-   ##
================================================
  Coverage               ?   73.7472%           
================================================
  Files                  ?       1085           
  Lines                  ?     349502           
  Branches               ?          0           
================================================
  Hits                   ?     257748           
  Misses                 ?      75297           
  Partials               ?      16457           

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 05:35:47.219634329 +0000 UTC m=+2931344.806744459: ☑️ agreed by hi-rustin.
  • 2023-10-31 09:20:57.98880973 +0000 UTC m=+2944855.575919875: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit b7f909c into pingcap:release-6.5 Oct 31, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants