ranger: split detach process from BuildRange. #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
reviewed
Oct 11, 2017
util/ranger/new_refiner.go
Outdated
| @@ -206,35 +211,42 @@ func buildColumnRange(conds []expression.Expression, sc *variable.StatementConte | |||
| return ranges, nil | |||
| } | |||
|
|
|||
| // DetachCondsForSelectivity distinguishes between conditions dor selectivity calculation and other conditions | |||
There was a problem hiding this comment.
dor? Also, Add a dot at the end.
shenli
reviewed
Oct 12, 2017
util/ranger/new_refiner.go
Outdated
| @@ -206,35 +211,42 @@ func buildColumnRange(conds []expression.Expression, sc *variable.StatementConte | |||
| return ranges, nil | |||
| } | |||
|
|
|||
| // DetachCondsForSelectivity distinguishes between conditions or selectivity calculation and other conditions. | |||
coocood
reviewed
Oct 12, 2017
| eqCount int | ||
| ) | ||
| for eqCount = 0; eqCount < len(accessCondition) && eqCount < len(cols); eqCount++ { | ||
| if sf, ok := accessCondition[eqCount].(*expression.ScalarFunction); !ok || sf.FuncName.L != ast.EQ { |
There was a problem hiding this comment.
The original is inAndEqCount, now only Eq is counted.
There was a problem hiding this comment.
in has be rewritten to or. Currently there won't be any in function any more.
|
PTAL @coocood |
|
LGTM |
coocood
approved these changes
Oct 12, 2017
|
/run-all-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildRangeis used when calculate range for scan plan and for selectivity. The detach process of this two situation won't be the same in the future, so split the detach process out of theBuildRangemethod.PTAL @coocood @hanfei1991 @lamxTyler