Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: avoid glog flags inject into tidb cli #47205

Merged
merged 7 commits into from
Sep 26, 2023
Merged

cli: avoid glog flags inject into tidb cli #47205

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50a7957
cli: avoid glog inject into tidb cli
hawkingrei Sep 22, 2023
60e1a9c
update
hawkingrei Sep 22, 2023
2a755d7
update
hawkingrei Sep 22, 2023
5a1f117
update
hawkingrei Sep 25, 2023
d2073c5
update
hawkingrei Sep 25, 2023
faab519
update
hawkingrei Sep 25, 2023
2297944
update
hawkingrei Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
  • Loading branch information
@hawkingrei
hawkingrei committed Sep 25, 2023
commit 2297944edd206ec57f51b656116f9bd1ec5f3a93
2 changes: 1 addition & 1 deletion config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,7 @@ func isAllRemovedConfigItems(items []string) bool {
// The function enforceCmdArgs is used to merge the config file with command arguments:
// For example, if you start TiDB by the command "./tidb-server --port=3000", the port number should be
// overwritten to 3000 and ignore the port number in the config file.
func InitializeConfig(confPath string, configCheck, configStrict bool, enforceCmdArgs func(*Config, fset *flag.FlagSet), fset *flag.FlagSet) {
func InitializeConfig(confPath string, configCheck, configStrict bool, enforceCmdArgs func(*Config, *flag.FlagSet), fset *flag.FlagSet) {
cfg := GetGlobalConfig()
var err error
if confPath != "" {
Expand Down