makefile: remove bazel_check before ut #46771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
hawkingrei
added
skip-issue-check
ti-chi-bot
bot
added
size/XS
xhebox
approved these changes
Sep 8, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46771 +/- ##
================================================
- Coverage 73.2940% 72.6853% -0.6087%
================================================
Files 1320 1342 +22
Lines 396084 402469 +6385
================================================
+ Hits 290306 292536 +2230
- Misses 87259 91375 +4116
- Partials 18519 18558 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zimulala
reviewed
Sep 8, 2023
updated. |
zimulala
approved these changes
Sep 11, 2023
| @@ -493,7 +493,7 @@ bazel_test: failpoint-enable bazel_prepare | |||
| -//tests/globalkilltest/... -//tests/readonlytest/... -//br/pkg/task:task_test -//tests/realtikvtest/... | |||
|
|
|||
|
|
|||
| bazel_coverage_test: check-bazel-prepare failpoint-enable bazel_ci_simple_prepare | |||
| bazel_coverage_test: failpoint-enable bazel_ci_simple_prepare | |||
There was a problem hiding this comment.
check dev also has this check, so we can remove the check here
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
avoid probably failure in the bazel_check
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.