-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
placement_rule: supports show origin placement rules #46750
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
Skipping CI for Draft Pull Request. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
efde137
to
b48c004
Compare
@HuSharp plz resolve conflicts and make it reviewable. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #46750 +/- ##
================================================
+ Coverage 71.0497% 71.6826% +0.6328%
================================================
Files 1368 1414 +46
Lines 401707 416758 +15051
================================================
+ Hits 285412 298743 +13331
- Misses 96439 99168 +2729
+ Partials 19856 18847 -1009
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6d2fe1c
to
c7ce059
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
c7ce059
to
870d46d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm. plz add some tests
/retest-required |
140b38e
to
b30059d
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nolouch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest-required t |
@HuSharp: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #46617
Problem Summary:
What is changed and how it works?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.