Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disttask: refactor scheduler part #46669

Merged
merged 11 commits into from
Sep 6, 2023
Merged

disttask: refactor scheduler part #46669

merged 11 commits into from
Sep 6, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Sep 5, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary:

What is changed and how it works?

  • rename prev Scheduler to SubtaskExecutor
  • rename prev SubtaskExecutor to MiniTaskExecutor
  • create a new Scheduler interface, and each task type should impl it based on BaseScheduler which is renamed from previous InternalScheduler, and register on framework part.
  • create new Extension interface to wrap create executor/miniTaskExecutor part, those don't need to be registered now.
  • other refactors

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 5, 2023
@tiprow
Copy link

tiprow bot commented Sep 5, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter
D3Hunter commented Sep 5, 2023
View reviewed changes
disttask/framework/scheduler/execute/interface.go
Copy link
Contributor Author

@D3Hunter D3Hunter Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid package dependency cycle

@D3Hunter D3Hunter changed the title [WIP]disttask: refactor scheduler part disttask: refactor scheduler part Sep 5, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 5, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 5, 2023
@D3Hunter D3Hunter requested review from tangenta and ywqzzy September 5, 2023 10:35
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #46669 (e18ea6f) into master (ca69622) will decrease coverage by 0.6928%.
Report is 2 commits behind head on master.
The diff coverage is 57.6576%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46669        +/-   ##
================================================
- Coverage   73.3566%   72.6638%   -0.6928%     
================================================
  Files          1318       1340        +22     
  Lines        395847     402072      +6225     
================================================
+ Hits         290380     292161      +1781     
- Misses        86993      91385      +4392     
- Partials      18474      18526        +52
Flag Coverage Δ
integration 25.3512% <6.0606%> (?)
unit 73.3562% <57.6576%> (-0.0004%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9689% <ø> (ø)
br 48.1465% <ø> (-4.3089%) ⬇️

tangenta
tangenta reviewed Sep 5, 2023
View reviewed changes
disttask/framework/scheduler/execute/interface.go
Comment on lines +41 to +42
// TODO: Rename to minimal task executor.
type MiniTaskExecutor interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not rename it directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove the todo when we remove MiniTaskExecutor

tangenta
tangenta reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@ywqzzy ywqzzy mentioned this pull request Sep 5, 2023
Closed
76 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-05 15:16:51.431722826 +0000 UTC m=+2458575.980738813: ☑️ agreed by tangenta.
  • 2023-09-06 02:33:20.936340319 +0000 UTC m=+2499165.485356291: ☑️ agreed by ywqzzy.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 6, 2023

/retest

6 similar comments
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 6, 2023

/retest

@tangenta
Copy link
Contributor

tangenta commented Sep 6, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 6, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 6, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 6, 2023

/retest

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 6, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit d703337 into master Sep 6, 2023
@ti-chi-bot ti-chi-bot bot deleted the refactor-scheduler branch September 6, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D3Hunter @tangenta @ywqzzy