-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disttask, ddl: refine disttask_flow #46472
Conversation
Skipping CI for Draft Pull Request. |
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46472 +/- ##
================================================
- Coverage 73.3859% 72.7436% -0.6423%
================================================
Files 1291 1323 +32
Lines 393578 401591 +8013
================================================
+ Hits 288831 292132 +3301
- Misses 86372 91002 +4630
- Partials 18375 18457 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
@ywqzzy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
func NewLitBackfillFlowHandle(d DDL) (dispatcher.TaskFlowHandle, error) { | ||
ddl, ok := d.(*ddl) | ||
if !ok { | ||
return nil, errors.New("The getDDL result should be the type of *ddl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we log here instead of return the error but ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore
I think current implementation is ok, we can't assume the d DDL
is *ddl
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #46258
Problem Summary:
What is changed and how it works?
Make the code cleaner.
Add realtikv test for non-partition table.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.