Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update the HTTP API about "upgrade" and fix a minor doc issue #46425

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 25, 2023

What problem does this PR solve?

Issue Number: close #46424

Problem Summary:

  • Update /upgrade?op={op} to /upgrade/{op} and add related doc
  • Fix a minor doc issue
    Before this PR:
截屏2023-08-25 16 11 31

After this PR:
截屏2023-08-25 16 14 41

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2023
@tiprow
Copy link

tiprow bot commented Aug 25, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 25, 2023
@Defined2014
Copy link
Contributor

Don't forget update user doc.

@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-25 08:43:53.621883079 +0000 UTC m=+1484598.170899051: ☑️ agreed by Defined2014.
  • 2023-08-25 08:57:41.098210066 +0000 UTC m=+1485425.647226050: ☑️ agreed by hawkingrei.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #46425 (a245c3a) into master (2adb1dc) will decrease coverage by 0.6814%.
Report is 4 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46425        +/-   ##
================================================
- Coverage   73.3923%   72.7110%   -0.6814%     
================================================
  Files          1295       1316        +21     
  Lines        393620     399843      +6223     
================================================
+ Hits         288887     290730      +1843     
- Misses        86361      90669      +4308     
- Partials      18372      18444        +72     
Flag Coverage Δ
integration 25.6256% <14.2857%> (?)
unit 73.3939% <100.0000%> (+0.0015%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0633% <ø> (ø)
br 47.9817% <ø> (-4.3490%) ⬇️

@ti-chi-bot ti-chi-bot bot merged commit 4d487cd into pingcap:master Aug 25, 2023
@zimulala zimulala deleted the zimuxia/upgrade-op branch August 25, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update /upgrade?op={op} to /upgrade/{op} and update docs
3 participants