Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove useless code #46408

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

CabinfeverB
Copy link
Contributor

@CabinfeverB CabinfeverB commented Aug 24, 2023

What problem does this PR solve?

Issue Number: close #46385

Problem Summary:

What is changed and how it works?

This issue arose after #45465, and #28555 caused it.
After #45465, runawayWatchSyncLoop will do ExecRestrictedSQL which will get the domain from the session, so domainMap will get or create it. #28555 deletes the store before closing the domain, which causes runawayWatchSyncLoop create a new Domain. So the domain created in TestBootstrapWithError can not become DDL owner and finish bootstrap.
We don't need to delete the store from domainMap because we will do it in Domain.Close.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2023
@tiprow
Copy link

tiprow bot commented Aug 24, 2023

Hi @CabinfeverB. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CabinfeverB
Copy link
Contributor Author

PTAL @Defined2014 @hawkingrei

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #46408 (46b6fde) into master (0564dcf) will decrease coverage by 0.6761%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46408        +/-   ##
================================================
- Coverage   73.3937%   72.7176%   -0.6761%     
================================================
  Files          1291       1316        +25     
  Lines        393577     399790      +6213     
================================================
+ Hits         288861     290718      +1857     
- Misses        86347      90638      +4291     
- Partials      18369      18434        +65     
Flag Coverage Δ
integration 25.6834% <ø> (?)
unit 73.3946% <ø> (+0.0009%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0633% <ø> (ø)
br 47.9714% <ø> (-4.2964%) ⬇️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 24, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 24, 2023
@Defined2014
Copy link
Contributor

/run-check-issue-triage-complete

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 16:08:12.27015209 +0000 UTC m=+1424856.819168062: ☑️ agreed by hawkingrei.
  • 2023-08-24 16:21:05.855355874 +0000 UTC m=+1425630.404371847: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 4c8e6af into pingcap:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestBootstrapWithError hang forever
3 participants