-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove useless code #46408
test: remove useless code #46408
Conversation
Hi @CabinfeverB. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PTAL @Defined2014 @hawkingrei |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46408 +/- ##
================================================
- Coverage 73.3937% 72.7176% -0.6761%
================================================
Files 1291 1316 +25
Lines 393577 399790 +6213
================================================
+ Hits 288861 290718 +1857
- Misses 86347 90638 +4291
- Partials 18369 18434 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
/run-check-issue-triage-complete |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #46385
Problem Summary:
What is changed and how it works?
This issue arose after #45465, and #28555 caused it.
After #45465,
runawayWatchSyncLoop
will doExecRestrictedSQL
which will get the domain from the session, sodomainMap
will get or create it. #28555 deletes the store before closing the domain, which causes runawayWatchSyncLoop create a new Domain. So the domain created inTestBootstrapWithError
can not become DDL owner and finishbootstrap
.We don't need to delete the store from
domainMap
because we will do it inDomain.Close
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.