-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoid_service: support keyspace has own auto id leader #46285
Conversation
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Hi @ystaticy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46285 +/- ##
================================================
- Coverage 73.3854% 73.3217% -0.0638%
================================================
Files 1285 1319 +34
Lines 394836 407005 +12169
================================================
+ Hits 289752 298423 +8671
- Misses 86633 90017 +3384
- Partials 18451 18565 +114
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
/test mysql-test |
@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
What problem does this PR solve?
Issue Number: ref #46286
Problem Summary:
What is changed and how it works?
Add keyspace prefix to the etcd path of the autoid leader for each keyspace.
Check List
Tests
Every keyspace has its own auto id leader.
keyspace-name="ks1"
keyspace-name="ks2"
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.