snap_restore: added retry for recovery (#46094) #46224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note
4 tasks
BornChanger
approved these changes
Aug 18, 2023
ti-chi-bot
added
the
cherry-pick-approved
Signed-off-by: hillium <yujuncen@pingcap.com>
YuJuncen
approved these changes
Aug 18, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46224 +/- ##
================================================
Coverage ? 73.6701%
================================================
Files ? 1084
Lines ? 347978
Branches ? 0
================================================
Hits ? 256356
Misses ? 75163
Partials ? 16459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #46094
What problem does this PR solve?
Issue Number: close #46181
Problem Summary:
Now, when TiKV reboots, it is possible to abort the whole restore procedure.
This PR has also introduced a new interface for retrying,
WithRetryV2, which supports returned value and move the closure to be retried last of the arguments. (So the code will probably be more readable, comparingWithRetry(ctx, backoffer, func() { /* multi lines */ })andWithRetry(ctx, func() { /* multi lines */ }, backoffer).What is changed and how it works?
This PR added retry to the
RecoverDatacall.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.