Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add reject metrics for LFU cache #46060

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 14, 2023

What problem does this PR solve?

Issue Number: close #46074

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #46060 (ed630fc) into master (9232aac) will decrease coverage by 2.0616%.
Report is 4 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46060        +/-   ##
================================================
- Coverage   74.7717%   72.7101%   -2.0616%     
================================================
  Files          1293       1300         +7     
  Lines        398152     399954      +1802     
================================================
- Hits         297705     290807      -6898     
- Misses        81089      90701      +9612     
+ Partials      19358      18446       -912     
Flag Coverage Δ
integration 25.5181% <25.0000%> (-20.7448%) ⬇️
unit 73.3878% <100.0000%> (+0.0301%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0548% <ø> (ø)
br 47.6414% <ø> (-16.8540%) ⬇️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei hawkingrei changed the title statistics: support reject for LFU cache statistics: add reject metrics for LFU cache Aug 14, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei requested a review from qw4990 August 14, 2023 10:31
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 14, 2023
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the dashboard?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hi-rustin,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-14 10:39:00.82828125 +0000 UTC m=+541105.377297236: ☑️ agreed by time-and-fate.
  • 2023-08-15 02:07:14.513949372 +0000 UTC m=+596799.062965344: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 55e36a5 into pingcap:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add monitoring for rejected writes in statscache LFU algorithm
3 participants