Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: reduce memory usage when to MergePartTopN2GlobalTopN (#45718) #45970

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45718

What problem does this PR solve?

Issue Number: close #45727

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

add some gobench for it.

Before:

Benchmark Iterations Time per Operation Memory Allocated Allocations per Operation
BenchmarkMergePartTopN2GlobalTopNWithHists100-8 85184 13737 ns/op 4408 B/op 53 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists1000-8 8985 136583 ns/op 40696 B/op 503 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists10000-8 702 1637701 ns/op 405880 B/op 5003 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists100000-8 48 23604707 ns/op 4000376 B/op 50003 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists1000000-8 5 235231317 ns/op 40002699 B/op 500003 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists10000000-8 1 17470526833 ns/op 400001144 B/op 5000003 allocs/op

After: #45718

Benchmark Iterations Time per Operation Memory Allocated Allocations per Operation
BenchmarkMergePartTopN2GlobalTopNWithHists100-8 103918 11497 ns/op 120 B/op 2 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists1000-8 10000 113324 ns/op 120 B/op 2 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists10000-8 909 1308099 ns/op 120 B/op 2 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists100000-8 63 17689263 ns/op 120 B/op 2 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists1000000-8 6 180973042 ns/op 120 B/op 2 allocs/op
BenchmarkMergePartTopN2GlobalTopNWithHists10000000-8 1 8101635583 ns/op 120 B/op 2 allocs/op
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 10, 2023
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 10, 2023
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 10, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hi-rustin,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-10 10:36:51.662186694 +0000 UTC m=+195376.211202680: ☑️ agreed by time-and-fate.
  • 2023-08-11 14:01:25.893193718 +0000 UTC m=+294050.442209705: ☑️ agreed by hi-rustin.

@hawkingrei
Copy link
Member

/retest

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@447ed39). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45970   +/-   ##
================================================
  Coverage               ?   73.6752%           
================================================
  Files                  ?       1083           
  Lines                  ?     347293           
  Branches               ?          0           
================================================
  Hits                   ?     255869           
  Misses                 ?      74996           
  Partials               ?      16428           

@ti-chi-bot ti-chi-bot bot merged commit dfe6238 into pingcap:release-6.5 Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants