Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix load data assertion failure (#43858) | tidb-test=pr/2145 #45825

Conversation

you06
Copy link
Contributor

@you06 you06 commented Aug 4, 2023

cherry pick #43858

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2023
@tiprow
Copy link

tiprow bot commented Aug 4, 2023

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

@crazycs520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 4, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, MyonKeminta, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-04 09:35:47.04115895 +0000 UTC m=+437230.983507481: ☑️ agreed by zyguan.
  • 2023-08-04 09:49:23.439020698 +0000 UTC m=+438047.381369258: ☑️ agreed by MyonKeminta.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

@you06: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

@tiprow I certainly trust myself~

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/test mysql-test tidb-test=pr/2145

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test tidb-test=pr/2145

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 4, 2023
@you06 you06 changed the title executor: fix load data assertion failure (#43858) executor: fix load data assertion failure (#43858) | tidb-test=pr/2145 Aug 4, 2023
@you06
Copy link
Contributor Author

you06 commented Aug 4, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

@you06: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 6e593be into pingcap:release-6.5-20230425-v6.5.2 Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants