Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump go.uber.org/zap from 1.24.0 to 1.25.0 #45808

Merged
merged 2 commits into from
Aug 4, 2023
Merged

build(deps): bump go.uber.org/zap from 1.24.0 to 1.25.0 #45808

merged 2 commits into from
Aug 4, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 4, 2023 •
edited by hawkingrei
Loading

Bumps go.uber.org/zap from 1.24.0 to 1.25.0.

Release notes

Sourced from go.uber.org/zap's releases.

v1.25.0

This release contains several improvements including performance, API additions, and two new experimental packages whose APIs are unstable and may change in the future.

Enhancements:

  • #1246[]: Add zap/exp/zapslog package for integration with slog.
  • #1273[]: Add Name to Logger which returns the Logger's name if one is set.
  • #1281[]: Add zap/exp/expfield package which contains helper methods Str and Strs for constructing String-like zap.Fields.
  • #1310[]: Reduce stack size on Any.

Thanks to @​knight42, @​dzakaammar, @​bcspragu, and @​rexywork for their contributions to this release.

#1246: uber-go/zap#1246 #1273: uber-go/zap#1273 #1281: uber-go/zap#1281 #1310: uber-go/zap#1310

Changelog

Sourced from go.uber.org/zap's changelog.

1.25.0 (1 Aug 2023)

This release contains several improvements including performance, API additions, and two new experimental packages whose APIs are unstable and may change in the future.

Enhancements:

  • #1246[]: Add zap/exp/zapslog package for integration with slog.
  • #1273[]: Add Name to Logger which returns the Logger's name if one is set.
  • #1281[]: Add zap/exp/expfield package which contains helper methods Str and Strs for constructing String-like zap.Fields.
  • #1310[]: Reduce stack size on Any.

Thanks to @​knight42, @​dzakaammar, @​bcspragu, and @​rexywork for their contributions to this release.

#1246: uber-go/zap#1246 #1273: uber-go/zap#1273 #1281: uber-go/zap#1281 #1310: uber-go/zap#1310

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@dependabot
build(deps): bump go.uber.org/zap from 1.24.0 to 1.25.0
cb48418 
Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 4, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 4, 2023

Hi @dependabot[bot]. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
update
faf4809 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 4, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 4, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 4, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #45808 (faf4809) into master (522a008) will increase coverage by 0.0054%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45808        +/-   ##
================================================
+ Coverage   73.3463%   73.3518%   +0.0054%     
================================================
  Files          1271       1274         +3     
  Lines        393001     393678       +677     
================================================
+ Hits         288252     288770       +518     
- Misses        86371      86498       +127     
- Partials      18378      18410        +32
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3435% <ø> (-0.0028%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (ø)
br 52.0253% <ø> (+0.0167%) ⬆️

@hawkingrei
Copy link
Member

/retest

@hawkingrei hawkingrei requested review from lance6716 and xhebox August 4, 2023 06:19
@lance6716
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-04 05:38:17.071078021 +0000 UTC m=+422981.013426549: ☑️ agreed by hawkingrei.
  • 2023-08-04 06:20:13.775956068 +0000 UTC m=+425497.718304596: ☑️ agreed by lance6716.

@hawkingrei
Copy link
Member

/retest

1 similar comment
@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 546b091 into master Aug 4, 2023
@ti-chi-bot ti-chi-bot bot deleted the dependabot/go_modules/go.uber.org/zap-1.25.0 branch August 4, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
approved dependencies Pull requests that update a dependency file lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkingrei @lance6716