Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix that get owner opValue before set this value when the etcdClient is nil #45393

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jul 17, 2023

What problem does this PR solve?

Issue Number: close #45392

Problem Summary:
If do GetOwnerOpValue before set this value when the etcdClient is nil, we may get a panic.
The above scenario can occur because DDL's startDispatchLoop operation is asynchronous.

What is changed and how it works?

Make sure the mockOwnerOpValue is initialized before GetOwnerOpValue in bootstrap.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2023
@tiprow
Copy link

tiprow bot commented Jul 17, 2023

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 17, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 17, 2023
@zimulala
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-17 10:05:55.777170578 +0000 UTC m=+931247.547509291: ☑️ agreed by Defined2014.
  • 2023-07-18 02:45:50.107032847 +0000 UTC m=+991241.877371560: ☑️ agreed by xhebox.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit c0e7057 into pingcap:master Jul 18, 2023
@zimulala zimulala deleted the zimuxia/mock-mgr-stable branch July 18, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB-server panicked during start without etcdClient
4 participants