-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner: fix that get owner opValue before set this value when the etcdClient is nil #45393
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
Issue Number: close #45392
Problem Summary:
If do
GetOwnerOpValue
before set this value when the etcdClient is nil, we may get a panic.The above scenario can occur because DDL's
startDispatchLoop
operation is asynchronous.What is changed and how it works?
Make sure the
mockOwnerOpValue
is initialized before GetOwnerOpValue in bootstrap.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.