planner: fix bug in PhysicalTableReader::Clone()

[windtalker]

What problem does this PR solve?

Issue Number: close #45299

Problem Summary:

What is changed and how it works?

Fix PhysicalTableReader::Clone, so PhysicalTableReader::TablePlans are still extracted from PhysicalTableReader::tablePlan

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[SeaRise]

/cc @SeaRise

[SeaRise]

Does other TableReader like PhysicalIndexReader need to be fixed?

	if cloned.indexPlan, err = p.indexPlan.Clone(); err != nil {
		return nil, err
	}
	if cloned.IndexPlans, err = clonePhysicalPlan(p.IndexPlans); err != nil {
		return nil, err
	}

[windtalker]

Yes, I think you are right, and it does not cause a bug because indexPlan is not used during execution time.

[SeaRise]

ok

[hawkingrei]

/ok-to-test

[hawkingrei]

/retest

[hawkingrei]

/retest

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-07-11 11:00:34.113521027 +0000 UTC m=+416125.883859740: ☑️ agreed by qw4990.
• 2023-07-12 01:41:39.899122714 +0000 UTC m=+468991.669461435: ☑️ agreed by SeaRise.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.4: #45307.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #45308.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #45309.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #45310.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.3: #45311.