Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping golang version to 1.9 #4527

Merged
merged 6 commits into from
Sep 20, 2017
Merged

Bumping golang version to 1.9 #4527

merged 6 commits into from
Sep 20, 2017

Conversation

ngaut
Copy link
Member

@ngaut ngaut commented Sep 14, 2017

No description provided.

@coocood
Copy link
Member

coocood commented Sep 14, 2017

https://github.com/pingcap/tidb/blob/master/circle.yml#L6

Circle CI may need to update as well.

@coocood
Copy link
Member

coocood commented Sep 14, 2017

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Sep 15, 2017

Go 1.9 runs many concurrent processes to compile, link and run, the memory usage is very high.
cover mode takes even more memory, that's why travis failed.

@zimulala zimulala merged commit a1654d9 into master Sep 20, 2017
@zimulala zimulala deleted the ngaut-bumping-go-version branch September 20, 2017 02:38
mccxj added a commit to mccxj/tidb that referenced this pull request Oct 9, 2017
See pingcap#4527 Bumping golang version to 1.9.
coocood pushed a commit that referenced this pull request Oct 9, 2017
See #4527 Bumping golang version to 1.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants