-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importinto/lightning: do remote checksum via sql (#44803) #45195
importinto/lightning: do remote checksum via sql (#44803) #45195
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@@ -309,7 +309,7 @@ func (ti *TableImporter) checksumTable(ctx context.Context) error { | |||
} | |||
} | |||
ti.logger.Info("local checksum", zap.Object("checksum", &localChecksum)) | |||
manager := local.NewTiKVChecksumManager(ti.kvStore.GetClient(), ti.backend.GetPDClient(), uint(ti.distSQLScanConcurrency)) | |||
manager := local.NewTiKVChecksumManager(ti.kvStore.GetClient(), ti.backend.GetPDClient(), uint(ti.distSQLScanConcurrency), local.DefaultBackoffWeight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
physical mode on 7.1 is disabled, so here we just use the default weight
/run-integration-br-test |
/hold until integration test pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-integration-br-test |
/run-integration-br-test |
1 similar comment
/run-integration-br-test |
/unhold |
9709d8e
into
pingcap:release-7.1-20230706-v7.1.0
This is an automated cherry-pick of #44803
What problem does this PR solve?
Issue Number: close #41941 , ref #44711
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.