Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: mark background and resource group name when in local mode #44950
lightning: mark background and resource group name when in local mode #44950
Changes from all commits
9715ec2
55cc1dc
bbbc1ed
3572739
738d769
046ea66
d211c08
e241ccb
893e10e
7cbdcb3
cab823a
b06854c
097e55a
5c19ae7
cda08bf
a2b0085
d2e3430
ad92415
4dccba1
7c0a646
2ca33d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 131 in br/cmd/tidb-lightning-ctl/main.go
Codecov / codecov/patch
br/cmd/tidb-lightning-ctl/main.go#L131
Check warning on line 143 in br/pkg/checksum/executor.go
Codecov / codecov/patch
br/pkg/checksum/executor.go#L142-L143
Check warning on line 282 in br/pkg/lightning/backend/local/checksum.go
Codecov / codecov/patch
br/pkg/lightning/backend/local/checksum.go#L282
Check warning on line 289 in br/pkg/lightning/backend/local/checksum.go
Codecov / codecov/patch
br/pkg/lightning/backend/local/checksum.go#L284-L289
Check warning on line 428 in br/pkg/lightning/backend/local/local.go
Codecov / codecov/patch
br/pkg/lightning/backend/local/local.go#L428
Check warning on line 449 in br/pkg/lightning/backend/local/local.go
Codecov / codecov/patch
br/pkg/lightning/backend/local/local.go#L449
Check warning on line 621 in br/pkg/lightning/common/util.go
Codecov / codecov/patch
br/pkg/lightning/common/util.go#L620-L621
Check warning on line 661 in br/pkg/lightning/common/util.go
Codecov / codecov/patch
br/pkg/lightning/common/util.go#L658-L661
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it fail when the target cluster is lower version? Is this by design?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check warning on line 69 in br/pkg/lightning/importer/checksum_helper.go
Codecov / codecov/patch
br/pkg/lightning/importer/checksum_helper.go#L64-L69