Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: wait schema change before rename table job is done (#43341) #44936

Merged
merged 4 commits into from
Jun 29, 2023
Merged

ddl: wait schema change before rename table job is done (#43341) #44936

merged 4 commits into from
Jun 29, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43341

What problem does this PR solve?

Issue Number: close #43338

Problem Summary:

What is changed and how it works?

We split the renaming table job into two steps:

  1. rename table and update the schema version.
  2. update the job state to JobStateDone.

This is the requirement from TiCDC because

  • it uses the job state to check whether the DDL is finished.
  • there is a gap between schema reloading and job state updating:
    when the job state is updated to JobStateDone, before the new schema reloaded,
    there may be DMLs that use the old schema.
  • TiCDC cannot handle the DMLs that use the old schema, because
    the commit TS of the DMLs are greater than the job state updating TS.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta @ti-chi-bot
This is an automated cherry-pick of pingcap#43341
0e2d8e5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 26, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jun 26, 2023
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2023
YangKeao
YangKeao approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 26, 2023
@tangenta
Copy link
Contributor

/retest

1 similar comment
@YangKeao
Copy link
Member

/retest

@tangenta
Copy link
Contributor

/retest

2 similar comments
@tangenta
Copy link
Contributor

/retest

@mjonss
Copy link
Contributor

mjonss commented Jun 29, 2023

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-26 07:03:28.629620227 +0000 UTC m=+604774.030870663: ☑️ agreed by YangKeao.
  • 2023-06-29 10:47:55.397778568 +0000 UTC m=+877440.799029016: ☑️ agreed by mjonss.

@ti-chi-bot ti-chi-bot bot merged commit 04ad9d4 into pingcap:release-6.1 Jun 29, 2023
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

@tangenta tangenta

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @tangenta @YangKeao @mjonss