Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Prune go_repository from bazel deps #44889

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jun 21, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@dveeden dveeden requested a review from hawkingrei June 21, 2023 16:06
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2023
@tiprow tiprow bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Jun 21, 2023
@tiprow
Copy link

tiprow bot commented Jun 21, 2023

Hi @dveeden. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 21, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Jun 21, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 21, 2023
@dveeden dveeden requested review from lance6716 and Defined2014 June 21, 2023 16:11
@dveeden
Copy link
Contributor Author

dveeden commented Jun 21, 2023

CI was failing due to this:

ERROR: /home/dvaneeden/.cache/bazel/_bazel_dvaneeden/e5ba616db02502a6138902055f41cb18/external
/io_etcd_go_etcd_api_v3/etcdserverpb/BUILD.bazel:3:11: no such package 
'@org_golang_google_genproto_googleapis_api//annotations': The repository 
'@org_golang_google_genproto_googleapis_api' could not be resolved: Repository 
'@org_golang_google_genproto_googleapis_api' is not defined and referenced by 
'@io_etcd_go_etcd_api_v3//etcdserverpb:etcdserverpb'
$ git grep 'org_golang_google_genproto_googleapis_api'
build/patches/io_etcd_go_etcd_api_v3.patch:+        "@org_golang_google_genproto_googleapis_api//annotations:annotations",

@dveeden dveeden requested a review from hawkingrei June 21, 2023 18:20
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 21, 2023

@hawkingrei: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test tiprow_fast_test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 22, 2023

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-integration-br-test
  • /test pull-integration-mysql-test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-21 16:09:41.70410998 +0000 UTC m=+205547.105360428: ☑️ agreed by hawkingrei.
  • 2023-06-22 01:38:09.359157981 +0000 UTC m=+239654.760408427: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit b6bc752 into pingcap:master Jun 22, 2023
@dveeden dveeden mentioned this pull request Aug 2, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants