Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add CTEProducer that shared by all CTEExec (#44643) | tidb-test=pr/2135 #44836

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 20, 2023

This is an automated cherry-pick of #44643 #44782

What problem does this PR solve?

Issue Number: close #44649

Problem Summary: As issue comment said: #44649 (comment)

What is changed and how it works?

Before: For different CTE references(a.k.a. CTEExec) that use one CTE definition. They will only have one PhysicalPlan of the CTE defition. But we will build CTE definition multiple time for each CTE references.

After: Add CTEProducer struct, it corresponsds to CTE defition and will only build once. These different CTEExec will read from the same CTEProducer.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1-20230515-v6.1.6 labels Jun 20, 2023
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge guo-shaoge requested a review from wshwsh12 June 20, 2023 10:59
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge guo-shaoge changed the title executor: add CTEProducer that shared by all CTEExec (#44643) executor: add CTEProducer that shared by all CTEExec (#44643) | tidb-test=pr/2135 Jun 20, 2023
wshwsh12
wshwsh12 previously approved these changes Jun 20, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 20, 2023
@guo-shaoge
Copy link
Collaborator

/test mysql-test

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Copy link
Collaborator

Also cherry pick #44782

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-20 11:43:13.836082823 +0000 UTC m=+103159.237333271: ☑️ agreed by wshwsh12.
  • 2023-06-20 12:08:17.183274668 +0000 UTC m=+104662.584525103: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit c8fe5cd into pingcap:release-6.1-20230515-v6.1.6 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1-20230515-v6.1.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants