Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add max query duration per resource group metrics #44746

Merged
merged 2 commits into from
Jun 17, 2023
Merged

metrics: add max query duration per resource group metrics #44746

merged 2 commits into from
Jun 17, 2023

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Jun 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #43691

Problem Summary:

What is changed and how it works?

Add max query duration per resource group metrics
截屏2023-06-16 21 46 28

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Connor1996
add max query duration per resource group metrics
6570d5e 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2023
@Connor1996 Connor1996 mentioned this pull request Jun 17, 2023
Closed
28 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 17, 2023
@glorv
Copy link
Contributor

glorv commented Jun 17, 2023

/retest

CabinfeverB
CabinfeverB reviewed Jun 17, 2023
View reviewed changes
Copy link
Contributor

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u paste a grafana UI screenshot?

@Connor1996
tiny adjust
d9bd40d 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

Can u paste a grafana UI screenshot?

updated

@Connor1996
Copy link
Member Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-17 00:58:46.829188113 +0000 UTC m=+392923.243792192: ☑️ agreed by glorv.
  • 2023-06-17 07:13:07.151059936 +0000 UTC m=+415383.565664015: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit b754f88 into pingcap:master Jun 17, 2023
@Connor1996 Connor1996 deleted the metrics branch June 17, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB left review comments

@glorv glorv glorv approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Connor1996 @glorv @nolouch @CabinfeverB