Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix uuid panic when expression index enabled #44516

Merged
merged 5 commits into from
Jun 9, 2023
Merged

lightning: fix uuid panic when expression index enabled #44516

merged 5 commits into from
Jun 9, 2023

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #44497

Problem Summary:

What is changed and how it works?

Add e.SessionCtx.Vars.TxnCtx when getting default value for column with default expression.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    manually load data with uuid and it works.

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

lightning: fix the problem that lightning crashes when target table has a column whose default value is uuid

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 8, 2023
lance6716
lance6716 reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/tests/lightning_generated_columns/data/gencol.uuid.0 copy.sql Outdated Show resolved Hide resolved
br/tests/lightning_generated_columns/run.sh Outdated Show resolved Hide resolved
@lance6716
Copy link
Contributor

/hold

waiting for lightning CI

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2023
@lichunzhu
Copy link
Contributor Author

/run-integration-br-test

@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.5-20230608-v6.5.2

@lichunzhu
Copy link
Contributor Author

/run-integration-br-test

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@purelind
Copy link
Contributor

purelind commented Jun 8, 2023

/test all

@lichunzhu
Copy link
Contributor Author

/run-integration-br-test

@lichunzhu
Copy link
Contributor Author

/check-issue-triage-complete

@lichunzhu
Copy link
Contributor Author

/run-integration-br-test

2 similar comments
@lichunzhu
Copy link
Contributor Author

/run-integration-br-test

@lichunzhu
Copy link
Contributor Author

/run-integration-br-test

@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2023
@lichunzhu
Copy link
Contributor Author

/merge

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 9, 2023

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 9, 2023
@lichunzhu
Copy link
Contributor Author

/merge

@lance6716
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 9, 2023
@lichunzhu
Copy link
Contributor Author

/merge

GMHDBJD
GMHDBJD approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, lance6716, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 06:17:52.594063436 +0000 UTC m=+65486.841985256: ☑️ agreed by lance6716.
  • 2023-06-09 06:28:52.430798121 +0000 UTC m=+66146.678719946: ☑️ agreed by GMHDBJD.

@lichunzhu
Copy link
Contributor Author

/merge

@lichunzhu
Copy link
Contributor Author

/test check-dev

@ti-chi-bot ti-chi-bot bot merged commit 33236ef into pingcap:master Jun 9, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2023
Open
3 tasks
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-6.5-20230608-v6.5.2: #44547.

In response to this:

/cherry-pick release-6.5-20230608-v6.5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 9, 2023
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#44516
5aec663 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44548.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2023
Merged
3 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 9, 2023
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#44516
a3c13e5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2023
Merged
3 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44549.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 9, 2023
@ti-chi-bot
lightning: fix uuid panic when expression index enabled (#44516) (#44548
43cf5ea 
)

close #44497
@GMHDBJD GMHDBJD mentioned this pull request Jun 25, 2023
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2023
@ti-chi-bot
lightning: fix uuid panic when expression index enabled (#44516) (#44549
a5ad6d3 
)

close #44497
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-6.1: #46724.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 6, 2023
Open
3 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2023
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#44516
5882f7a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: fail to import data into tables with expression index enabled
7 participants
@lichunzhu @lance6716 @purelind @wuhuizuo @ti-chi-bot @D3Hunter @GMHDBJD