-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/gcworker: reduce "full config reset" log on pd side (#44331) #44347
store/gcworker: reduce "full config reset" log on pd side (#44331) #44347
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/merge |
@tiancaiamao: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/test all |
@purelind: No presubmit jobs available for pingcap/tidb@release-7.1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #44331
What problem does this PR solve?
Issue Number: close #33069
Problem Summary:
What is changed and how it works?
Similiar to #33082, reduce the duplicated request.
If there are N range to be deleted, there will be N logs like "full config reset" on the pd side.
It affects v6.1.1 and master both.
doGCPlacementRules
function for eachDelRangeTask
tidb/store/gcworker/gc_worker.go
Line 924 in b7d3c08
doGCPlacementRules
get the DDL history by theDelRangeTask.JobID
tidb/store/gcworker/gc_worker.go
Line 2165 in b7d3c08
tidb/store/gcworker/gc_worker.go
Line 2179 in b7d3c08
tidb/store/gcworker/gc_worker.go
Line 2220 in b7d3c08
There are many duplicated physical IDs during step 1 and step 3
In #33069 it add a cache to handle the Delete rule
But note this line
tidb/store/gcworker/gc_worker.go
Line 2220 in b7d3c08
Check List
Tests
After the fix, there would be only one line "full config reset" in the log for the drop table operation.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.