Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/gcworker: reduce "full config reset" log on pd side (#44331) #44347

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44331

What problem does this PR solve?

Issue Number: close #33069

Problem Summary:

What is changed and how it works?

Similiar to #33082, reduce the duplicated request.

If there are N range to be deleted, there will be N logs like "full config reset" on the pd side.
It affects v6.1.1 and master both.

  1. (*GCWorker).deleteRanges execute doGCPlacementRules function for each DelRangeTask
    if err := w.doGCPlacementRules(se, safePoint, r, gcPlacementRuleCache); err != nil {
  2. doGCPlacementRules get the DDL history by the DelRangeTask.JobID
    historyJob, err = ddl.GetHistoryJobByID(se, dr.JobID)
  3. Retrive all the Physical Table IDs dropped by this DDL
    if err = historyJob.DecodeArgs(&startKey, &physicalTableIDs); err != nil {
  4. And delete all the Bundles for those Physical Table IDs
    return infosync.PutRuleBundlesWithDefaultRetry(context.TODO(), bundles)

There are many duplicated physical IDs during step 1 and step 3

In #33069 it add a cache to handle the Delete rule
But note this line

return infosync.PutRuleBundlesWithDefaultRetry(context.TODO(), bundles)
, there would still be duplicated request there, so pd print "full config reset" many times.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
update mysql.tidb set VARIABLE_VALUE = '3m' where VARIABLE_NAME = 'tikv_gc_run_interval';
update mysql.tidb set VARIABLE_VALUE = '3m' where VARIABLE_NAME = 'tikv_gc_life_time';

create table t (id int) partition by hash partitions 2000;
insert into t values (1),(2),(3), ....
insert into t select * from t;

drop table t;

wait 3min, check the pd log ...

After the fix, there would be only one line "full config reset" in the log for the drop table operation.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/cherry-pick-for-release-6.5-20230425-v6.5.2 labels Jun 2, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jun 2, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 7, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lcwangchao,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-07 05:42:18.46970989 +0000 UTC m=+51430.240048594: ☑️ agreed by tiancaiamao.
  • 2023-07-07 05:53:23.228320606 +0000 UTC m=+52094.998659319: ☑️ agreed by lcwangchao.

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

@tiancaiamao: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@purelind
Copy link
Contributor

/test all

@tiprow
Copy link

tiprow bot commented Jul 10, 2023

@purelind: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 71d2cfd into pingcap:release-7.1 Jul 10, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230425-v6.5.2 type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants